wp-login.php login_header Title tag missing

[ravipatel]

do_action( 'login_header' );
?>
    <div id="login">
            <h1><a href="<?php echo esc_url($login_header_url); ?>"><?php echo $login_header_text; ?></a></h1>
	

Change Code With

do_action( 'login_header' );
	?>
    <div id="login">
        <h1><a href="<?php echo esc_url($login_header_url); ?>" title="<?php echo $login_header_text; ?>"><?php echo $login_header_text; ?></a></h1>
	

[davidbaumwald]

@ravipatel Great job so far. I think the title should incorporate esc_attr as well.

[ravipatel]

Patch file for code

[ravipatel]

@davidbaumwald I have updated code with patch please proceed for this, Please guide me if need any process for this. I have updated with esc_attr()

[ravipatel]

latest code with esc_attr

[davidbaumwald]

Looks like this was discussed and removed in #42537.

[SergeyBiryukov]

Hi @ravipatel, thanks for the patch!

The title attribute was intentionally removed from login_header() in [44899] to improve accessibility. See #42537 for more details.

[ravipatel]

[42537] @SergeyBiryukov ok, I have reviewed these changes. But as per HTML rules, a tag required a title tag.

[SergeyBiryukov]

Replying to ravipatel:

But as per HTML rules, a tag required a title tag.

HTML indeed requires the ​title tag, but it's not the same as the ​title attribute (see also the ​Accessibility concerns section for the latter).