WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#47330 closed defect (bug) (wontfix)

wp-login.php login_header Title tag missing

Reported by: ravipatel Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.2
Component: Login and Registration Keywords: has-patch needs-testing
Focuses: accessibility Cc:

Description

do_action( 'login_header' );
?>
    <div id="login">
            <h1><a href="<?php echo esc_url($login_header_url); ?>"><?php echo $login_header_text; ?></a></h1>
	

Change Code With

do_action( 'login_header' );
	?>
    <div id="login">
        <h1><a href="<?php echo esc_url($login_header_url); ?>" title="<?php echo $login_header_text; ?>"><?php echo $login_header_text; ?></a></h1>
	

Attachments (2)

47330.patch (600 bytes) - added by ravipatel 2 months ago.
Patch file for code
47330.2.patch (612 bytes) - added by ravipatel 2 months ago.
latest code with esc_attr

Download all attachments as: .zip

Change History (6)

#1 @davidbaumwald
2 months ago

  • Focuses accessibility added
  • Keywords needs-refresh added

@ravipatel Great job so far. I think the title should incorporate esc_attr as well.

@ravipatel
2 months ago

Patch file for code

#2 @ravipatel
2 months ago

@davidbaumwald I have updated code with patch please proceed for this, Please guide me if need any process for this. I have updated with esc_attr()

Last edited 2 months ago by ravipatel (previous) (diff)

@ravipatel
2 months ago

latest code with esc_attr

#3 @davidbaumwald
2 months ago

  • Keywords needs-refresh removed

Looks like this was discussed and removed in #42537.

#4 @SergeyBiryukov
2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Hi @ravipatel, thanks for the patch!

The title attribute was intentionally removed from login_header() in [44899] to improve accessibility. See #42537 for more details.

Note: See TracTickets for help on using tickets.