![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#47330 closed defect (bug) (wontfix)
wp-login.php login_header Title tag missing
| Reported by: | ravipatel | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Login and Registration | Version: | 5.2 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: | Focuses: | accessibility |
Description
do_action( 'login_header' );
?>
<div id="login">
<h1><a href="<?php echo esc_url($login_header_url); ?>"><?php echo $login_header_text; ?></a></h1>
Change Code With
do_action( 'login_header' );
?>
<div id="login">
<h1><a href="<?php echo esc_url($login_header_url); ?>" title="<?php echo $login_header_text; ?>"><?php echo $login_header_text; ?></a></h1>
Attachments (2)
Change History (8)
#2
@
7 years ago
@davidbaumwald I have updated code with patch please proceed for this, Please guide me if need any process for this. I have updated with esc_attr()
#3
@
7 years ago
- Keywords needs-refresh removed
Looks like this was discussed and removed in #42537.
#5
follow-up:
↓ 6
@
6 years ago
[42537] @SergeyBiryukov ok, I have reviewed these changes. But as per HTML rules, a tag required a title tag.
#6
in reply to: ↑ 5
@
6 years ago
Replying to ravipatel:
But as per HTML rules, a tag required a title tag.
HTML indeed requires the title tag, but it's not the same as the title attribute (see also the Accessibility concerns section for the latter).
Note:
See TracTickets
for help on using tickets.
@ravipatel Great job so far. I think the title should incorporate
esc_attras well.