WordPress.org

Make WordPress Core

Opened 4 weeks ago

Closed 4 weeks ago

#47332 closed enhancement (fixed)

Edit link icon missing in TwentyNineteen(1.4) content-page.php

Reported by: ounziw Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-patch commit has-screenshots
Focuses: Cc:

Description (last modified by SergeyBiryukov)

"Edit link" for posts has an icon:

https://themes.trac.wordpress.org/browser/twentynineteen/1.4/inc/template-tags.php#L129
is

'<span class="edit-link">' . twentynineteen_get_icon_svg( 'edit', 16 ),

"Edit link" for pages has no icon:

https://themes.trac.wordpress.org/browser/twentynineteen/1.4/template-parts/content/content-page.php#L50
is

'<span class="edit-link">',

Attachments (4)

47332.diff (551 bytes) - added by mukesh27 4 weeks ago.
Patch.
47332-post-edit.PNG (5.8 KB) - added by ianbelanger 4 weeks ago.
Post edit-link
47332-page-edit.PNG (766 bytes) - added by ianbelanger 4 weeks ago.
Page edit-link before patch
47332-page-edit-after-patch.PNG (925 bytes) - added by ianbelanger 4 weeks ago.
Page edit-link after patch

Download all attachments as: .zip

Change History (9)

@mukesh27
4 weeks ago

Patch.

#1 @mukesh27
4 weeks ago

  • Component changed from Themes to Bundled Theme
  • Keywords has-patch added
  • Version 5.2 deleted

@ounziw it was not necessary that we need to add and icon for edit. Let's wait for core dev reply.

@laurelfulford can you please check it.

#2 @SergeyBiryukov
4 weeks ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 5.3

#3 @ianbelanger
4 weeks ago

  • Keywords commit added

It appears that the edit icon was added to the post edit-link to match the rest of the items in the entry-footer. author, date and categories all have icons. See screenshot below.

IMO we should add the icon to the page edit-link as well, just for consistency. 47332.diff looks like a good solution and works well for me, going to mark this for commit.

Thanks for reporting @ounziw and thanks for your patch @mukesh27

@ianbelanger
4 weeks ago

Post edit-link

@ianbelanger
4 weeks ago

Page edit-link before patch

@ianbelanger
4 weeks ago

Page edit-link after patch

#4 @ianbelanger
4 weeks ago

  • Keywords has-screenshots added

#5 @SergeyBiryukov
4 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45397:

Twenty Nineteen: Add missing icon to Edit link for pages.

Props mukesh27, ianbelanger, ounziw.
Fixes #47332.

Note: See TracTickets for help on using tickets.