Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#47358 closed defect (bug) (fixed)

Strings incorrect punctuation

Reported by: pedromendonca's profile pedromendonca Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

The below strings has wrong punctuation.

1) Both singular and plural should end with ".":
https://build.trac.wordpress.org/browser/trunk/wp-admin/link-manager.php#L111

%s link deleted.
%s links deleted -> %s links deleted.

2) Option name shouldn't end with "." for consistency with the other options:
https://build.trac.wordpress.org/browser/trunk/wp-admin/options-discussion.php#L91

Show comments cookies opt-in checkbox, allowing comment author cookies to be set

3) The ending punctuation "." should be outside the “Run the installation” mention:
https://build.trac.wordpress.org/browser/trunk/wp-admin/setup-config.php#L412

After you've done that, click “Run the installation.”
After you've done that, click “Run the installation”.

Attachments (1)

47358.diff (2.0 KB) - added by pedromendonca 5 years ago.
Patch

Download all attachments as: .zip

Change History (5)

@pedromendonca
5 years ago

Patch

#1 in reply to: ↑ description @pedromendonca
5 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.3

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45382:

I18N: Make punctuation in some wp-admin strings more consistent.

Props pedromendonca.
Fixes #47358.

#4 @peterwilsoncc
4 years ago

#48218 was marked as a duplicate.

Note: See TracTickets for help on using tickets.