WordPress.org

Make WordPress Core

Opened 3 weeks ago

Last modified 4 days ago

#47366 new defect (bug)

Privacy Policy page dropdown needs a max-width

Reported by: SergeyBiryukov Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Privacy Keywords: good-first-bug has-screenshots has-patch needs-design-feedback needs-refresh
Focuses: ui, administration Cc:

Description (last modified by SergeyBiryukov)

Previously: #19613, #19782, #21956.

If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

See the screenshot.

Attachments (8)

47366.png (41.8 KB) - added by SergeyBiryukov 3 weeks ago.
47366.diff (357 bytes) - added by mukesh27 3 weeks ago.
Patch.
Screen Shot 2019-05-24 at 11.40.50 AM.png (333.1 KB) - added by desrosj 3 weeks ago.
Screen Shot 2019-05-24 at 11.40.27 AM.png (385.8 KB) - added by desrosj 3 weeks ago.
Screen Shot 2019-05-24 at 11.40.20 AM.png (390.8 KB) - added by desrosj 3 weeks ago.
47366.2.diff (364 bytes) - added by desrosj 3 weeks ago.
47366.reading-settings.png (14.6 KB) - added by SergeyBiryukov 3 weeks ago.
47366.options-reading-max-width-100%.png (131.7 KB) - added by mukesh27 3 weeks ago.
Fix with max-width 100%

Download all attachments as: .zip

Change History (15)

@SergeyBiryukov
3 weeks ago

#1 @SergeyBiryukov
3 weeks ago

  • Description modified (diff)

@mukesh27
3 weeks ago

Patch.

#2 @mukesh27
3 weeks ago

  • Keywords has-patch added; needs-patch removed

Attached patch that add max-width in select tag.

#3 @desrosj
3 weeks ago

  • Keywords needs-design-feedback added

47366.2.diff uses 100% instead, which allows the <select> to fill the width of the screen on smaller orientations.

I am tagging as needs-design-feedback because on medium screens, the dropdown and button do not align with other elements on the page and the button is butting against the dropdown.

@desrosj
3 weeks ago

#4 @SergeyBiryukov
3 weeks ago

Looks like the same issue also applies to Reading Settings: 47366.reading-settings.png.

@mukesh27
3 weeks ago

Fix with max-width 100%

#5 @mukesh27
3 weeks ago

If we use max-width: 100%; here then it will not resolve our issue. check 47366.options-reading-max-width-100%.png​ attached screenshot.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


4 days ago

#7 @desrosj
4 days ago

  • Keywords needs-refresh added

47366.2.diff only targets the privacy policy tools page. The patch needs to be refreshed to include a more general fix that will help with 47366.reading-settings.png.

Note: See TracTickets for help on using tickets.