WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#47386 closed defect (bug) (fixed)

Fix headings hierarchy in the legacy Custom Background and Custom Header pages

Reported by: afercia Owned by: afercia
Priority: normal Milestone: 5.2.3
Component: Themes Version:
Severity: normal Keywords: has-screenshots has-patch needs-testing fixed-major
Cc: Focuses: accessibility

Description

In the Custom Background and Custom Header admin pages, the headings hierarchy skips one heading level, see attached screenshots.

Though these pages are legacy, fixing it is really simple and improves the experience for users who use themes with no Customizer support for header and background images.

Attachments (3)

01 Screenshot 2019-05-25 at 15.11.07.jpg​ (115.2 KB ) - added by afercia 7 years ago.
02 Screenshot 2019-05-25 at 15.11.22.jpg​ (84.6 KB ) - added by afercia 7 years ago.
47386.diff​ (1.2 KB ) - added by afercia 7 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
7 years ago

@afercia
7 years ago

@afercia
7 years ago

#1 @afercia
7 years ago

  • Keywords has-patch added

#2 @afercia
7 years ago

  • Owner set to afercia
  • Resolution → fixed
  • Status new → closed

In 45411:

Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.

Fixes #47386.

#3 @JeffPaul
7 years ago

  • Keywords needs-testing fixed-major added
  • Milestone 5.3 → 5.2.3
  • Resolution fixed
  • Status closed → reopened

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

#4 @SergeyBiryukov
7 years ago

  • Resolution → fixed
  • Status reopened → closed

In 45839:

Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.

Props afercia.
Merges [45411] to the 5.2 branch.
Fixes #47386.

Note: See TracTickets for help on using tickets.