WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 4 months ago

#47386 closed defect (bug) (fixed)

Fix headings hierarchy in the legacy Custom Background and Custom Header pages

Reported by: afercia Owned by: afercia
Milestone: 5.2.3 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-screenshots has-patch needs-testing fixed-major
Focuses: accessibility Cc:
PR Number:

Description

In the Custom Background and Custom Header admin pages, the headings hierarchy skips one heading level, see attached screenshots.

Though these pages are legacy, fixing it is really simple and improves the experience for users who use themes with no Customizer support for header and background images.

Attachments (3)

01 Screenshot 2019-05-25 at 15.11.07.jpg (115.2 KB) - added by afercia 7 months ago.
02 Screenshot 2019-05-25 at 15.11.22.jpg (84.6 KB) - added by afercia 7 months ago.
47386.diff (1.2 KB) - added by afercia 7 months ago.

Download all attachments as: .zip

Change History (7)

@afercia
7 months ago

#1 @afercia
7 months ago

  • Keywords has-patch added

#2 @afercia
7 months ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 45411:

Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.

Fixes #47386.

#3 @JeffPaul
4 months ago

  • Keywords needs-testing fixed-major added
  • Milestone changed from 5.3 to 5.2.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

#4 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45839:

Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.

Props afercia.
Merges [45411] to the 5.2 branch.
Fixes #47386.

Note: See TracTickets for help on using tickets.