Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#47387 closed enhancement (wontfix)

Need to do formatting while declaring variables.

Reported by: priyankkpatel Owned by:
Priority: normal Milestone:
Component: External Libraries Version:
Severity: normal Keywords: has-patch
Cc: Focuses: coding-standards

Description

Need to do some formatting in wp-includes/class-json.php while declaring variables.

Attachments (1)

47387.diff (989 bytes ) - added by priyankkpatel 7 years ago.
Patch for wp-includes/class-json.php

Download all attachments as: .zip

Change History (3)

@priyankkpatel
7 years ago

Patch for wp-includes/class-json.php

#1 @ocean90
7 years ago

  • Milestone Awaiting Review
  • Resolutionwontfix
  • Status newclosed
  • Version 5.2.1

Hello @priyankkpatel, thanks for the patch but the file is a third-party library which we usually don’t modify. It’s also excluded in our PHPCS config, see https://core.trac.wordpress.org/browser/trunk/phpcs.xml.dist?rev=44955#L89.

#2 @SergeyBiryukov
7 years ago

  • Component GeneralExternal Libraries
Note: See TracTickets for help on using tickets.