WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#47387 closed enhancement (wontfix)

Need to do formatting while declaring variables.

Reported by: priyankkpatel Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch
Focuses: coding-standards Cc:

Description

Need to do some formatting in wp-includes/class-json.php while declaring variables.

Attachments (1)

47387.diff (989 bytes) - added by priyankkpatel 11 months ago.
Patch for wp-includes/class-json.php

Download all attachments as: .zip

Change History (3)

@priyankkpatel
11 months ago

Patch for wp-includes/class-json.php

#1 @ocean90
11 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version 5.2.1 deleted

Hello @priyankkpatel, thanks for the patch but the file is a third-party library which we usually don’t modify. It’s also excluded in our PHPCS config, see https://core.trac.wordpress.org/browser/trunk/phpcs.xml.dist?rev=44955#L89.

#2 @SergeyBiryukov
11 months ago

  • Component changed from General to External Libraries
Note: See TracTickets for help on using tickets.