Missing docs for filters in site health check

[johnbillion]

The site health check implements filters which haven't been documented.

• automatic_updater_disabled (Ref)
• automatic_updates_is_vcs_checkout (Ref)
• allow_dev_auto_core_updates (Ref)
• allow_minor_auto_core_updates (Ref)

These need to be documented or linked to their canonical documentation.

[johnbillion]

In addition, using these filters instead of appropriate functions or methods doesn't seem correct to me. For example, the WP_Upgrader::is_vcs_checkout() method should probably be used in place of the automatic_updates_is_vcs_checkout filter.

[mukesh27]

Patch.

[desrosj]

I agree that the automatic_updates_is_vcs_checkout filter should be replaced by the WP_Upgrader::is_vcs_checkout() as there is a lot of duplicated code, but there are some trade offs. The error message would become much less specific, for example. The checked directory and VCS directory would not be available currently without copying the logic over from the WP_Upgrader method and those are specifically mentioned in the messaging. The filter would also still need to be run to detect a change in value.

Let's add the missing documentation here and open a new ticket to explore ways to remove the duplicated code.

[desrosj]

In 45459:

Administration: Add missing filter documentation for Site Health auto update tests.

Props johnbillion, mukesh27.
Fixes #47388.

[desrosj]

Reopening for backport consideration. Opened #47428 for discussion around improving the version control test.

[desrosj]

Documentation fixes are not usually backported. Let's leave this in 5.3.