Opened 6 years ago
Closed 5 years ago
#47390 closed defect (bug) (fixed)
Improve accessibility of forms elements within some "form-table" forms
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.2.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch has-screenshots needs-testing fixed-major |
Focuses: | accessibility, multisite, privacy | Cc: |
Description
Follow-up to #46899.
In #46899, an attribute role="presentation"
was added to most of the form-table
used in the admin pages. These tables contain forms and in most of the cases they are used just for layout purposes. The role="presentation"
helps in removing the table semantics where appropriate.
Note: this should be considered a temporary improvement, pending decision on the proposal to entirely remove layout tables from WordPress. See #16413, #18801, #39441, and the explorations made on https://github.com/wpaccessibility/settings-api-enhanced.
That said, there are a few cases where the semantics of these forms within tables can be improved. I'm working on a patch to address these cases.
Attachments (5)
Change History (11)
#4
@
6 years ago
- Owner set to afercia
- Resolution set to fixed
- Status changed from new to closed
In 45416:
47390.diff does the following:
role="presentation"
to the edit comment layout table<fieldset>
elements<label>
elements, especially on some network admin pagesclass="td-full"
to table rows spanning to multiple cellsscope="row"
attribute to the table headers inoptions-permalink.php
: this table is better communicated as data tablearia-describedby
user-edit.php
pageRe: the "Privacy Settings" page, the select label should be the bold text in the left column. I'd like to propose to remove
Select an existing page:
and just use the left column text as the<label>
, also for consistency with all the similar settings tables in the admin. See attached screenshots.