WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 8 weeks ago

#47392 reviewing defect (bug)

Update date_query condition to verify param data in proper order

Reported by: vishalkakadiya Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Date/Time Keywords: has-patch
Focuses: Cc:

Description

Here the code is doing something that it's using array values like $date_queryrelation? first then it's checking for ! is_array which looking not proper and also we are checking empty value late so I have updated them in this PR.

Let me know if any other changes needed here. Thanks!

Attachments (1)

47392.diff (1.0 KB) - added by vishalkakadiya 2 months ago.

Download all attachments as: .zip

Change History (4)

#1 @mukesh27
8 weeks ago

  • Component changed from General to Date/Time
  • Version trunk deleted

@vishalkakadiya good cache. i have tested above patch it working fine for me.

@desrosj can you please check it.

This ticket was mentioned in Slack in #core-datetime by rarst. View the logs.


8 weeks ago

#3 @SergeyBiryukov
8 weeks ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.