WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47411, comment 12


Ignore:
Timestamp:
09/15/2019 10:07:16 AM (7 years ago)
Author:
SergeyBiryukov

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #47411, comment 12

    initial v1  
    11Replying to [comment:11 azaozz]:
    2 > At this point I'm starting to wonder why WPCS is checking line endings at all? Do we expect git and svn to be buggy and fail? How was this handled before the had WPCS sniffs, were there any "line endings accidents"?
     2> At this point I'm starting to wonder why WPCS is checking line endings at all? Do we expect git and svn to be buggy and fail?
     3
     4Good point, I'm also curious about why this check was needed in the first place.
     5
     6> How was this handled before the had WPCS sniffs, were there any "line endings accidents"?
    37
    48#28187 comes to mind, but it doesn't look like WPCS would help there, as it appears to be an issue with develop → core SVN sync script, not with the files themselves.