WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #47411, comment 14


Ignore:
Timestamp:
10/29/2019 02:21:54 PM (7 years ago)
Author:
SergeyBiryukov

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #47411, comment 14

    v2 v3  
    11Related: [46586-46588] for #42594.
    22
    3 It's a bit awkward that `phpcbf` and `phpcs` convert all files to `\n` and enforce Unix EOLs on Windows, then SVN converts them back to `\r\n`, and so on.
     3[46586] made #31432 much more prominent. Basically any test with a multiline string output now fails on Windows, seeing 47 failures on trunk.
     4
     5It's also bit awkward that `phpcbf` and `phpcs` convert all files to `\n` and enforce Unix EOLs on Windows, then SVN converts them back to `\r\n`, and so on.
    46
    57Seems like we have two options here: