WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 8 weeks ago

#47414 closed defect (bug) (fixed)

Twenty Seventeen: Button block preview has extra spacing within button

Reported by: nayana123 Owned by: SergeyBiryukov
Milestone: 5.2.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing fixed-major
Focuses: ui Cc:
PR Number:

Description (last modified by laurelfulford)

Theme issue: Twenty Seventeen (v2.2)

Steps to Follow:

  1. Active Twenty Seventeen theme.
  2. Open Editor.
  3. Add button Block.
  4. Note that the button is very tall, and runs behind the link field.
  5. Add text to the button; the issue will go away.

Please find below attached video:

https://www.screencast.com/t/nEclKgbAbRDR


Attachments (6)

Screen Shot 2019-06-03 at 8.44.50 PM.png (46.8 KB) - added by laurelfulford 4 months ago.
Twenty Seventeen - button without text
Screen Shot 2019-06-03 at 8.45.01 PM.png (41.4 KB) - added by laurelfulford 4 months ago.
Twenty Seventeen - button with text
47414.diff (1.0 KB) - added by ianbelanger 4 months ago.
Updates Twenty Seventeen and Twenty Eleven
47414-twentyeleven-before-patch.PNG (6.1 KB) - added by ianbelanger 4 months ago.
47414-twentyeleven-after-patch.PNG (5.3 KB) - added by ianbelanger 4 months ago.
47414-twentyseventeen-after-patch.PNG (6.5 KB) - added by ianbelanger 4 months ago.

Download all attachments as: .zip

Change History (18)

#1 @laurelfulford
4 months ago

  • Component changed from Themes to Bundled Theme
  • Description modified (diff)
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.3
  • Summary changed from Button Design should be proper , when we add the button block and check different style preview. to Twenty Seventeen: Button block preview has extra spacing within button

@laurelfulford
4 months ago

Twenty Seventeen - button without text

@laurelfulford
4 months ago

Twenty Seventeen - button with text

@ianbelanger
4 months ago

Updates Twenty Seventeen and Twenty Eleven

#2 @ianbelanger
4 months ago

  • Keywords has-patch added; needs-patch removed

I also found this same issue in Twenty Eleven, the patch fixes both themes. All of the other Bundled Themes seem to be fine. Screenshots coming

#3 @SergeyBiryukov
2 months ago

In 45763:

Twenty Eleven: Correct height for a Button block without text.

Props ianbelanger, laurelfulford, nayana123.
See #47414.

#4 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45764:

Twenty Seventeen: Correct height for a Button block without text.

Props ianbelanger, laurelfulford, nayana123.
Fixes #47414.

#5 @JeffPaul
2 months ago

  • Keywords needs-testing fixed-major added
  • Milestone changed from 5.3 to 5.2.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

This ticket was mentioned in Slack in #core by marybaum. View the logs.


8 weeks ago

#7 @SergeyBiryukov
8 weeks ago

Two fixes here:

At the latest bug scrub, a decision was made to backport only [45764] to the 5.2 branch, and keep [45763] for 5.3.

#8 @SergeyBiryukov
8 weeks ago

In 45860:

Twenty Eleven: Adjust [45763] to conform to CSS Coding Standards.

See #47414.

#9 @SergeyBiryukov
8 weeks ago

In 45861:

Twenty Seventeen: Adjust [45764] to conform to CSS Coding Standards.

See #47414.

#10 @SergeyBiryukov
8 weeks ago

In 45862:

Twenty Eleven: Fix tabs vs. spaces in [45763].

See #47414.

#11 @SergeyBiryukov
8 weeks ago

In 45863:

Twenty Seventeen: Fix tabs vs. spaces in [45764].

See #47414.

#12 @SergeyBiryukov
8 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45864:

Twenty Seventeen: Correct height for a Button block without text.

Props ianbelanger, laurelfulford, nayana123.
Merges [45764], [45861], and [45863] to the 5.2 branch.
Fixes #47414.

Note: See TracTickets for help on using tickets.