Media with fragments duplicate in enclosures

[dshanske]

I am using media fragment ids(​https://www.w3.org/TR/media-frags/) to specify retrieval points in audio/video and the enclosure code picks this up as different enclosures, so I have the same media file multiple times. Suggest duplicate checking in do_enclose after stripping the fragments.

[raaaahman]

Working on it at #WCEU

Edit: Didn't manage to solve it. Feel free to try.

[archduck]

Strip fragments from url

[archduck]

It looks like do_enclose does some checking for duplicate urls already, when it runs the enclosure_links filter - but it doesn't take url fragments into account. This patch adds a check for fragments on new urls and strips them away if present. It only affects the enclosures, so the rest of the markup stays intact.

[dshanske]

@archduck Why check for fragments when the strip fragment function strips regardless? Isn't in more efficient just to run everything through it?

[archduck]

Replying to dshanske:

@archduck Why check for fragments when the strip fragment function strips regardless? Isn't in more efficient just to run everything through it?

Good point. Checking for fragments with parse_url is an unnecessary step here.

Especially since strip_fragment_from_url itself runs parse_url - and so urls with fragments would undergo parse_url a second time.

Better to just send everything through it.

[archduck]

Send all the urls through the fragslasher

[audrasjb]

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

[Mista-Flo]

Could you please give some steps to reproduce? How can I test to add media fragment to my dev website?

It would allow us to write a unit test for it.

[dshanske]

Add multiple urls to a post that are the same mp3 file, adding ?t=130, ?t=145, etc.

[helen]

For those of us who are not RSS spec experts, could I get a brief overview of what multiple enclosures are meant to be used for and what issues it causes to have the same media item but with different fragments represented as multiple enclosures?

I deal with enclosures but only in the context of a podcasting plugin that doesn't currently have any workflow for something like timestamp indicators, I suppose it would not be good for the podcast RSS feed to have the same item multiple times?

[dshanske]

@helen Enclosures are used for podcasts.. usually multiple enclosures would reflect a video and an audio file..this is generating multiple versions of the same file... creates podcatcher issues

[helen]

@dshanske Thanks! I'll leave this in 5.6 for the moment then.

[helen]

In 49552:

Feeds: Don't treat media URLs with fragments as unique for enclosures.

Props archduck, dshanske.
Fixes #47421.