Opened 7 years ago
Closed 7 years ago
#47424 closed defect (bug) (fixed)
Need to add comment before function definition,
| Reported by: | priyankkpatel | Owned by: | desrosj |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.3 |
| Component: | Upgrade/Install | Version: | 2.9 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | docs |
Description
Function 'list_plugin_updates' is defined without adding comment above it in wp-admin/update-core.php.
Attachments (5)
Change History (15)
#1
@
7 years ago
- Component Comments → Upgrade/Install
- Focuses docs added
- Milestone Awaiting Review → 5.3
#2
@
7 years ago
@priyankkpatel list_plugin_updates function is introduce in WordPress version 2.9.0
#4
follow-ups:
↓ 6
↓ 8
@
7 years ago
- Owner set to
- Status new → reviewing
- Type enhancement → defect (bug)
Looks like list_plugin_updates() was actually included in 2.7 in changeset [9543].
Thanks for this, @priyankkpatel!
#6
in reply to: ↑ 4
@
7 years ago
- Keywords needs-patch added; has-patch removed
- Resolution fixed
- Status closed → reopened
Replying to desrosj:
Looks like
list_plugin_updates()was actually included in 2.7 in changeset [9543].
[9543] did not introduce any new functions, it moved list_core_update() and some related functions from wp-admin/update.php to wp-admin/update-core.php.
list_plugin_updates() and list_theme_updates() were both added in [12066] for #10973, that's 2.9.
While we're at it, let's add missing descriptions for other functions in that file:
dismissed_updates()list_theme_updates()list_translation_updates()do_dismiss_core_update()do_undismiss_core_update()
#7
@
7 years ago
@SergeyBiryukov I've updated the descriptions for the other functions in that file. Is it good to go now?
@mukesh27 Any thoughts on this? ;)
#8
in reply to: ↑ 4
@
7 years ago
Replying to desrosj:
Looks like
list_plugin_updates()was actually included in 2.7 in changeset [9543].
Thanks for this, @priyankkpatel!
You are welcome.
#9
@
7 years ago
- Keywords has-patch commit added; needs-patch removed
- Version trunk → 2.9
Thanks @ajayghaghretiya1!
47424.4.diff has some minor updates to those descriptions and includes the @since tag fix that @SergeyBiryukov mentioned above.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Patch for wp-admin/update-core.php