WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47424 closed defect (bug) (fixed)

Need to add comment before function definition,

Reported by: priyankkpatel's profile priyankkpatel Owned by: desrosj's profile desrosj
Milestone: 5.3 Priority: normal
Severity: normal Version: 2.9
Component: Upgrade/Install Keywords: has-patch commit
Focuses: docs Cc:

Description

Function 'list_plugin_updates' is defined without adding comment above it in wp-admin/update-core.php.

Attachments (5)

47424.diff​ (608 bytes) - added by priyankkpatel 5 years ago.
Patch for wp-admin/update-core.php
47424.2.diff​ (522 bytes) - added by mukesh27 5 years ago.
Updated patch.
47424.3.diff​ (608 bytes) - added by priyankkpatel 5 years ago.
formatting updated comment.
update-description.diff​ (823 bytes) - added by ajayghaghretiya1 5 years ago.
Updated the description for the other functions in the update-core.php file.
47424.4.diff​ (1015 bytes) - added by desrosj 5 years ago.

Download all attachments as: .zip

Change History (15)

@priyankkpatel
5 years ago

Patch for wp-admin/update-core.php

#1 @SergeyBiryukov
5 years ago

  • Component changed from Comments to Upgrade/Install
  • Focuses docs added
  • Milestone changed from Awaiting Review to 5.3

@mukesh27
5 years ago

Updated patch.

#2 @mukesh27
5 years ago

@priyankkpatel list_plugin_updates function is introduce in WordPress version 2.9.0

@priyankkpatel
5 years ago

formatting updated comment.

#3 @priyankkpatel
5 years ago

@mukesh27 Thank you for the update.

#4 follow-ups: @desrosj
5 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing
  • Type changed from enhancement to defect (bug)

Looks like list_plugin_updates() was actually included in 2.7 in changeset [9543].

Thanks for this, @priyankkpatel!

#5 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45480:

Docs: Add missing function documentation for list_plugin_updates().

Introduced in [9543].

Props priyankkpatel, mukesh27.
Fixes #47424.

#6 in reply to: ↑ 4 @SergeyBiryukov
5 years ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to desrosj:

Looks like list_plugin_updates() was actually included in 2.7 in changeset [9543].

[9543] did not introduce any new functions, it moved list_core_update() and some related functions from wp-admin/update.php to wp-admin/update-core.php.

list_plugin_updates() and list_theme_updates() were both added in [12066] for #10973, that's 2.9.

While we're at it, let's add missing descriptions for other functions in that file:

  • dismissed_updates()
  • list_theme_updates()
  • list_translation_updates()
  • do_dismiss_core_update()
  • do_undismiss_core_update()

@ajayghaghretiya1
5 years ago

Updated the description for the other functions in the update-core.php file.

#7 @ajayghaghretiya1
5 years ago

@SergeyBiryukov I've updated the descriptions for the other functions in that file. Is it good to go now?

Version 0, edited 5 years ago by ajayghaghretiya1 (next)

#8 in reply to: ↑ 4 @priyankkpatel
5 years ago

Replying to desrosj:

Looks like list_plugin_updates() was actually included in 2.7 in changeset [9543].

Thanks for this, @priyankkpatel!

You are welcome.

@desrosj
5 years ago

#9 @desrosj
5 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Version changed from trunk to 2.9

Thanks @ajayghaghretiya1!

47424.4.diff​ has some minor updates to those descriptions and includes the @since tag fix that @SergeyBiryukov mentioned above.

#10 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46161:

Docs: Add missing descriptions for functions in wp-admin/update-core.php.

Also, fix the @since annotation added in [45480] to include the correct version.

Props SergeyBiryukov, ajayghaghretiya1.
Fixes #47424.

Note: See TracTickets for help on using tickets.