Make WordPress Core

Opened 5 years ago

Closed 14 months ago

#47434 closed feature request (maybelater)

Consider updating CSSLint manually

Reported by: vedjain's profile vedjain Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: External Libraries Keywords:
Focuses: Cc:


We bundle CSSLint in Core. Unfortunately, they have not had a new release in some time now, which means that some rules like mix-blend-mode are merged, but not yet available in any release version.

Ideally this should be fixed upstream, but please consider updating CSSLint files manually, so that additional rules also becomes available. We include CSSLint via script.

Change History (4)

#1 @desrosj
5 years ago

  • Component changed from General to External Libraries

#2 @desrosj
4 years ago

  • Keywords needs-patch early added

Hi @vedjain!

Welcome to Trac! My apologies that it took a while to receive a response.

While updating external libraries separately from a library versioned release is sometimes done, reaching out to the maintainers for CSSLint and working with them to release a new version is the much preferred option. Especially where there are 24 commits since the last release and not just one or two changes (full change log since 1.0.3).

Looking at the CSSLint repository, there has also only been one commit in the last year, and a few more than 3 in the last 2 years. Another approach would be to see if there are better maintained more modern alternatives to CSSLint that could be looked at. For this option, all use within WordPress Core would need to be documented.

I'm also marking this as an early ticket. When the library is updated, it's preferable to do so early on in the release cycle to ensure proper testing occurs.

#3 @desrosj
4 years ago

  • Milestone changed from Awaiting Review to Future Release

Actually, I just looked again and noticed some strangeness.

It looks like the version of CSSLint packaged with WordPress is 1.0.5. However, if you open the file, the version in the docblock is 1.0.4.

The latest released version in the GitHub repo is 1.0.3. However, if you look in the dist/ folder, the packaged file is versioned as 1.0.5. It seems that a contributor had the permission to merge commits but not to tag a release.

CSSLint is also included as a part of CodeMirror. CSSLint should probably be updated with that library.

#4 @desrosj
14 months ago

  • Keywords needs-patch early removed
  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Unfortunately, I think it's safe to say CSSLint is deprecated. I'm going to close this one out as maybe later.

The recommendation on the issue linked above is to use Stylelint. It may be worth exploring how to deprecate CSSLint in Core and switch to using a maintained linter.

Related: #48456 (updating CodeMirror to the latest version).

Note: See TracTickets for help on using tickets.