WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 32 hours ago

Last modified 16 hours ago

#47437 closed defect (bug) (fixed)

Update tinymce 4.x

Reported by: pross Owned by: azaozz
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

Couple of days ago tinymce finally fixed the firefox Error: Permission denied to access property "nodeType": bug.

See:
https://github.com/WordPress/gutenberg/issues/6703
https://github.com/WordPress/gutenberg/issues/4744

Tinymce bug:
https://github.com/tinymce/tinymce/issues/2194

The fix was in the 5.x version of tinymce but I requested that it be backported to 4.x so as soon as they build a release it can be updated in WordPress.

Attachments (1)

47437.patch (735.9 KB) - added by pross 4 months ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
4 months ago

  • Component changed from Editor to TinyMCE
  • Milestone changed from Awaiting Review to 5.3

@pross
4 months ago

#3 @Presskopp
4 days ago

  • Keywords has-patch added

#4 follow-up: @azaozz
32 hours ago

@pross thanks for the patch but it has to include the default TinyMCE plugins used in WP and the theme. Generally not worth it making a patch as it is mostly copy/paste of the new files, and the patch gets far too big :)

#5 @azaozz
32 hours ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 46173:

TinyMCE: update to version 4.9.6. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt. Includes fix for the Permission denied to access property "nodeType" error.

Fixes #47437.

#6 in reply to: ↑ 4 @pross
16 hours ago

Replying to azaozz:

@pross thanks for the patch but it has to include the default TinyMCE plugins used in WP and the theme. Generally not worth it making a patch as it is mostly copy/paste of the new files, and the patch gets far too big :)

Thanks for including the fix.

Note: See TracTickets for help on using tickets.