WordPress.org

Make WordPress Core

Opened 2 weeks ago

Last modified 2 weeks ago

#47463 reviewing enhancement

Refactor from using invalid timestamps in event filtering

Reported by: Rarst Owned by: SergeyBiryukov
Milestone: 5.3 Priority: low
Severity: minor Version:
Component: Date/Time Keywords: has-patch
Focuses: Cc:

Description

Event API sends WordCamp and Meetup data with date/time lacking time zone information (see https://meta.trac.wordpress.org/ticket/4480 )

The current implementation of filtering for upcoming events tries to parse that into timestamps (which doesn't really work) and determine upcoming events by comparing against "WP timestamp" summed with time zone offset (which isn't really appropriate for the task, or ever).

Patch simplifies the logic to date comparison and removes reliance on WP timestamp.

Parent issue #40657

Attachments (1)

trim-events.patch (1.2 KB) - added by Rarst 2 weeks ago.

Download all attachments as: .zip

Change History (3)

@Rarst
2 weeks ago

#1 @Rarst
2 weeks ago

  • Summary changed from Refactor from using invalid timestamps in event filtreing to Refactor from using invalid timestamps in event filtering

#2 @SergeyBiryukov
2 weeks ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.