WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#47475 closed defect (bug) (fixed)

I18n: Merge similar strings and fix typo

Reported by: pedromendonca Owned by: SergeyBiryukov
Milestone: 5.2.2 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:
PR Number:

Description

1) The below strings are similar and can be merged by changing %1$s to %s.
https://build.trac.wordpress.org/browser/trunk/wp-admin/includes/file.php#L1222

The authenticity of %1$s could not be verified as signature verification is unavailable on this system.
The authenticity of %s could not be verified as signature verification is unavailable on this system.

2) The below string has a comma that should be placed outside the quotation marks:
“white screen of death,” -> “white screen of death”,

https://build.trac.wordpress.org/browser/trunk/wp-admin/about.php#L100

This administrator-focused update will let you safely fix or manage fatal errors without requiring developer time. It features better handling of the so-called “white screen of death,” and a way to enter recovery mode, which pauses error-causing plugins or themes.

Attachments (3)

47475.diff (1.6 KB) - added by pedromendonca 6 months ago.
Patch to fix strings
47475.2.diff (1.7 KB) - added by garrett-eclipse 6 months ago.
Removes double space after comma, fixes translator comment to use %s instead of 1
47475.3.diff (1.7 KB) - added by garrett-eclipse 6 months ago.
Minor to change 'requiring developer time' to 'requiring a developer'

Download all attachments as: .zip

Change History (13)

@pedromendonca
6 months ago

Patch to fix strings

#1 @SergeyBiryukov
6 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.2.2
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Thanks for the patch!

“white screen of death,” was previously discussed in #46901, but for some reason was missed in [45278].

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


6 months ago

@garrett-eclipse
6 months ago

Removes double space after comma, fixes translator comment to use %s instead of 1

#3 @garrett-eclipse
6 months ago

Thanks for the initial patch @pedromendonca I've made two minor tweaks in 47475.2.diff;

  1. In the white screen of death string there was two spaces after one of the commas so I dropped the extra one.
  2. I've updated the translator comment preceeding the authenticity string you updated to indicate '%s' as it was previously '1:'.

Another minor grammar thought not sure if this ticket is the right place though but...
Original - "This administrator-focused update will let you safely fix or manage fatal errors without requiring developer time."
I wonder if this string would read better as 'requiring a developer' instead of 'requiring developer time', so would be;
Suggested - "This administrator-focused update will let you safely fix or manage fatal errors without requiring a developer."

Cheers

@garrett-eclipse
6 months ago

Minor to change 'requiring developer time' to 'requiring a developer'

#4 @garrett-eclipse
6 months ago

I've also added 47475.3.diff just in case we want to slide this verbiage update in as well;

Another minor grammar thought not sure if this ticket is the right place though but...
Original - "This administrator-focused update will let you safely fix or manage fatal errors without requiring developer time."
I wonder if this string would read better as 'requiring a developer' instead of 'requiring developer time', so would be;
Suggested - "This administrator-focused update will let you safely fix or manage fatal errors without requiring a developer."

#5 @pedromendonca
6 months ago

Thanks @garrett-eclipse for the aditions in 47475.2.diff, I've missed those and are perfect now.

About the grammar change added in 47475.3.diff, I think it's great and more correct.

All looks great and ready for me!

#6 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45515:

I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.

Props pedromendonca, garrett-eclipse.
Fixes #47475.

#7 @SergeyBiryukov
6 months ago

In 45516:

I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.

Props pedromendonca, garrett-eclipse.
Merges [45515] to the 5.2 branch.
Fixes #47475.

#8 @garrett-eclipse
6 months ago

Thanks for the commit @SergeyBiryukov
Appears the verbiage suggestion was overlooked in the commits so have moved it to a new ticket - #47538

#9 @desrosj
6 months ago

In 45551:

Help/About: Improve wording of PHP Error Protection section.

Props pedromendonca, garrett-eclipse.
See #47475.
Fixes #47538.

#10 @desrosj
6 months ago

In 45552:

Help/About: Improve wording of PHP Error Protection section.

Merges [45551] to the 5.2 branch.

Props pedromendonca, garrett-eclipse.
See #47475.
Fixes #47538.

Note: See TracTickets for help on using tickets.