#47475 closed defect (bug) (fixed)
I18n: Merge similar strings and fix typo
Reported by: | pedromendonca | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.2.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch |
Focuses: | Cc: |
Description
1) The below strings are similar and can be merged by changing to %1$s
%s
.
https://build.trac.wordpress.org/browser/trunk/wp-admin/includes/file.php#L1222
The authenticity of %1$s could not be verified as signature verification is unavailable on this system.
The authenticity of %s could not be verified as signature verification is unavailable on this system.
2) The below string has a comma that should be placed outside the quotation marks:
-> “white screen of death,”
“white screen of death”,
https://build.trac.wordpress.org/browser/trunk/wp-admin/about.php#L100
This administrator-focused update will let you safely fix or manage fatal errors without requiring developer time. It features better handling of the so-called “white screen of death,” and a way to enter recovery mode, which pauses error-causing plugins or themes.
Attachments (3)
Change History (13)
#1
@
6 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 5.2.2
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
6 years ago
#3
@
6 years ago
Thanks for the initial patch @pedromendonca I've made two minor tweaks in 47475.2.diff;
- In the white screen of death string there was two spaces after one of the commas so I dropped the extra one.
- I've updated the translator comment preceeding the authenticity string you updated to indicate '%s' as it was previously '1:'.
Another minor grammar thought not sure if this ticket is the right place though but...
Original - "This administrator-focused update will let you safely fix or manage fatal errors without requiring developer time."
I wonder if this string would read better as 'requiring a developer' instead of 'requiring developer time', so would be;
Suggested - "This administrator-focused update will let you safely fix or manage fatal errors without requiring a developer."
Cheers
#4
@
6 years ago
I've also added 47475.3.diff just in case we want to slide this verbiage update in as well;
Another minor grammar thought not sure if this ticket is the right place though but...
Original - "This administrator-focused update will let you safely fix or manage fatal errors without requiring developer time."
I wonder if this string would read better as 'requiring a developer' instead of 'requiring developer time', so would be;
Suggested - "This administrator-focused update will let you safely fix or manage fatal errors without requiring a developer."
#5
@
6 years ago
Thanks @garrett-eclipse for the aditions in 47475.2.diff, I've missed those and are perfect now.
About the grammar change added in 47475.3.diff, I think it's great and more correct.
All looks great and ready for me!
Patch to fix strings