Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#47481 closed enhancement (fixed)

Wrong arguments order in the_meta()

Reported by: loyaltymanufaktur Owned by: SergeyBiryukov
Priority: normal Milestone: 5.3
Component: Posts, Post Types Version: 1.0
Severity: minor Keywords: has-patch commit
Cc: Focuses: template

Description

./wp-includes/post-template.php:1107

$value  = implode( $values, ', ' );

The glue argument should be the first one:

$value  = implode( ', ', $values );

Attachments (1)

100644.patch (465 bytes ) - added by loyaltymanufaktur 7 years ago.

Download all attachments as: .zip

Change History (3)

#1 @ocean90
7 years ago

  • Keywords commit added
  • Milestone Awaiting Review5.3
  • Type defect (bug)enhancement
  • Version trunk1.0

Hello @loyaltymanufaktur, welcome to Trac!

Thanks for the ticket and the patch. As noted in the docs, "implode() can, for historical reasons, accept its parameters in either order". I'm fine with changing it, though.

Related: [946], [948]

#2 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 45491:

Posts, Post Types: Switch the order of arguments for implode() in the_meta() to match the function notation.

Props loyaltymanufaktur.
Fixes #47481.

Note: See TracTickets for help on using tickets.