Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#47481 closed enhancement (fixed)

Wrong arguments order in the_meta()

Reported by: loyaltymanufaktur's profile loyaltymanufaktur Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: minor Version: 1.0
Component: Posts, Post Types Keywords: has-patch commit
Focuses: template Cc:



$value  = implode( $values, ', ' );

The glue argument should be the first one:

$value  = implode( ', ', $values );

Attachments (1)

100644.patch (465 bytes) - added by loyaltymanufaktur 4 years ago.

Download all attachments as: .zip

Change History (3)

#1 @ocean90
4 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.3
  • Type changed from defect (bug) to enhancement
  • Version changed from trunk to 1.0

Hello @loyaltymanufaktur, welcome to Trac!

Thanks for the ticket and the patch. As noted in the docs, "implode() can, for historical reasons, accept its parameters in either order". I'm fine with changing it, though.

Related: [946], [948]

#2 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45491:

Posts, Post Types: Switch the order of arguments for implode() in the_meta() to match the function notation.

Props loyaltymanufaktur.
Fixes #47481.

Note: See TracTickets for help on using tickets.