WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 5 months ago

#47518 assigned enhancement

Add an explanatory message to the Revisions screen for locked posts

Reported by: johnbillion Owned by: adamsilverstein
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Revisions Keywords: needs-patch
Focuses: ui, javascript, administration Cc:

Description

It's possible for a user to navigate to the revisions screen for a post that's locked due to another user editing it, and not be able to restore any revisions due to the fact that the post is locked. In this situation no message is shown on the Revisions screen that explains why the Restore This Revision button is disabled.

Under normal operating procedure it's not easy to get to the Revisions screen for a locked post, but it is possible. A workflow related plugin, audit trail, or revisions list can make it possible to navigate directly to a revision without going via the otherwise locked editing screen.

  1. User A navigates to the revisions screen for a non-locked post.
  2. User B visits the editing screen for the post.
  3. User A clicks Return to editor on the revisions screen.
  4. User A chooses not to take over, and clicks Go back.

User A is now shown the revisions screen for a locked post and the Restore This Revision button is disabled for all revisions but with no explanatory information.

Change History (2)

#1 @SergeyBiryukov
2 years ago

  • Focuses ui added

#2 @adamsilverstein
5 months ago

  • Owner set to adamsilverstein
  • Status changed from new to assigned

User A is now shown the revisions screen for a locked post and the Restore This Revision button is disabled for all revisions but with no explanatory information.

Great suggestion @johnbillion - since the button is disabled we must be already detecting the lock state at load time.

I feel like this would be sufficient here (show the message if post locked at load time) vs. the polling/live lock detection we do on the post edit screen. What do you think?

Note: See TracTickets for help on using tickets.