WordPress.org

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #47527


Ignore:
Timestamp:
08/29/2019 02:18:35 PM (2 years ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47527

    • Property Milestone changed from Awaiting Review to 5.3
  • Ticket #47527 – Description

    initial v3  
    1 The visible class as the code comment specifies is used to "// Show the sidebar on mobile". This ensures that when a user selects an image on the media library even on mobile, the user can still see the image/file details.
     1The visible class as the code comment specifies is used to "''Show the sidebar on mobile''". This ensures that when a user selects an image on the media library even on mobile, the user can still see the image/file details.
    22This class is only added for insert frames. Insert frames are used by the classic editor to insert images, audio, and the media widgets also use them. Most tutorials I checked related to media library usage in plugins end up using the "library" frame, so I guess most plugins use this frame. The block editor also uses the library frame most of the times, so the block editor contains a bug where on mobile the media sidebar with the details of the selected file does not appear. I think this bug will also affect the media sidebar of most WordPress plugins.
    33