WordPress.org
Get WordPress

Make WordPress Core

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#4753 closed defect (bug) (invalid)

Simplify get_userdatabylogin

Reported by: filosofo's profile filosofo Owned by:
Milestone: Priority: low
Severity: normal Version: 2.3
Component: Administration Keywords: get_userdatabylogin get_userdata pluggable has-patch 2nd-opinion
Focuses: Cc:

Description

get_userdatabylogin duplicates get_userdata unnecessarily with direct calls to the database. The attached patch gets the userdata from get_userdata if it's not already cached.

Attachments (1)

simpler_get_userdatabylogin.diff​ (1.8 KB) - added by filosofo 17 years ago.

Download all attachments as: .zip

Change History (5)

@filosofo
17 years ago

#1 @DD32
17 years ago

  • Keywords needs-patch added

Relates to #5392. The get_userby... functions still have a lot of overlap though.

#2 @DD32
17 years ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed
  • Priority changed from normal to low

After the changes made in #5392 this looks much more invalid, The functions seem to have been normalised a fair bit with use of _fill_user(), and while it could be simplified down furthur, it doesnt look like thats needing to be a high priority.

#3 @filosofo
17 years ago

  • Resolution set to invalid
  • Status changed from new to closed

I agree. _fill_user has addressed everything I wanted originally.

#4 @Nazgul
17 years ago

  • Milestone 2.5 deleted
Note: See TracTickets for help on using tickets.