WordPress.org

Make WordPress Core

#47534 closed defect (bug) (fixed)

Customize: widgets search shouldn't show widgets on click on clear button

Reported by: Mahesh901122 Owned by: pento
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

On click on the close button after the widget search, it does not show all widgets.

See video before applying patch https://www.youtube.com/watch?v=7uwe5LF6kI8

After applying patch - https://www.youtube.com/watch?v=wYg15c_CrvQ

Attachments (1)

47534.patch (555 bytes) - added by Mahesh901122 16 months ago.

Download all attachments as: .zip

Change History (4)

#1 @Mahesh901122
16 months ago

I have found the same issue for the customizer menu item search box too. But the same patch not works for the menu items.

File: \src\js\_enqueues\wp\customize\nav-menus.js line 219:

self.$search.val( '' ).focus().trigger( 'keyup' );
self.collection.doSearch( '' ); // NEW CODE HERE TO RESET THE SEARCH.

But it not works for menu search. So, I have just created a patch for the customizer widget search.

Last edited 16 months ago by Mahesh901122 (previous) (diff)

#2 @pento
15 months ago

  • Keywords has-patch added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.3
  • Owner set to pento
  • Status changed from new to assigned

#3 @pento
15 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45658:

Customizer: Show all widgets when the search field is cleared.

When clicking the clear button on the widget search field, the search results should refresh to show all widgets.

Props Mahesh901122.
Fixes #47534.

Note: See TracTickets for help on using tickets.