WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47547


Ignore:
Timestamp:
06/18/2019 01:03:26 AM (5 years ago)
Author:
garrett-eclipse
Comment:

I may be off-base but I believe some findings here can shed some light; "switch_to_locale() only does something if the locale passed to it is different than the value of get_locale() outside of the admin. Inside the admin, it only switches if it's different than the locale of the current user."

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #47547 – Description

    initial v1  
    11Given a site that uses `en_US` as its language, a user with their user language set to something else, and that user logged into the admin dashboard, calling `switch_to_locale( 'en_US' )` appears to be unreliable.
    22
    3 1. ❌ The return value of `determine_locale()` is the user's language, not `en_US`.
    4 2. ✅ Localised text without a textdomain (ie. text from core) is correctly displayed in `en_US`.
    5 3. ❌ Localised text with a textdomain (ie. text from plugins or themes) is incorrectly displayed in the user's language. This may be related to #39210.
     31. The return value of `determine_locale()` is the user's language, not `en_US`.
     42. Localised text without a textdomain (ie. text from core) is correctly displayed in `en_US`.
     53. Localised text with a textdomain (ie. text from plugins or themes) is incorrectly displayed in the user's language. This may be related to #39210.
    66
    77Given a site that itself uses a language other than `en_US`, calling `switch_to_locale( 'en_US' )` does appear to work although I haven't tested it extensively.