#47561 closed defect (bug) (fixed)
Plugin: View details popup layout issue
Reported by: | mukesh27 | Owned by: | afercia |
---|---|---|---|
Milestone: | 5.2.3 | Priority: | normal |
Severity: | normal | Version: | 5.2.2 |
Component: | Plugins | Keywords: | has-patch has-screenshots fixed-major |
Focuses: | ui | Cc: |
Description
Attachments (11)
Change History (55)
#2
in reply to:
↑ 1
@
5 years ago
@SGr33n Is attached patch resolved issue for your setup?
Replying to SGr33n:
Watching, I was opening the same ticket :P
#5
@
5 years ago
- Keywords needs-testing needs-codex added
- Milestone changed from Awaiting Review to 5.3
- Priority changed from normal to high
- Severity changed from normal to major
Hi thanks for the report, I triaged the ticket in the next major release but we'll probably need a 5.2.3.
#7
@
5 years ago
I've found the issue happens on every plugin page -- seems to me that we can fix this with a couple of lines of CSS to change the positioning.
#8
@
5 years ago
If we add relative positioning to the parent element, #plugin-information.content.with-banner, and absolute positioning to the element itself, we fix the issue across the board.
This ticket was mentioned in Slack in #forums by clorith. View the logs.
5 years ago
#13
@
5 years ago
Thanks everyone for the ticket and patches. Touching the admin CSS is... challenging, even for minor changes :)
I'd tend to think a better fix would be removing the wrap
CSS class from the plugin details modal content area. wrap
has some styling (margins) that are specifically meant for the admin pages main content area. It shouldn't be used in other places. The styles needed for the modal content can be set directly on #section-holder
, which is used only in the plugin modal.
#15
@
5 years ago
Both 47561.2.diff and 47561.3.diff are fixing the issue, but I think @afercia’s approach is better, since there is less risk to remove an unused class. I also tested the path on mobile and it looks fine.
#16
@
5 years ago
@audrasjb patch working fine for me also and @afercia is better then others.
#17
@
5 years ago
- Keywords commit added; needs-testing removed
Thanks everyone. 47561.4.diff adjusts the margins that were previously set by the wrap
class, also when there's the warning notice displayed. See attached screenshot.
#18
@
5 years ago
- Priority changed from high to normal
- Severity changed from major to normal
Note for bug gardeners: while priority and severity are, to some extent, subjective calls, high
priority and major
severity should be used for bugs that really make a functionality not usable or trigger a crash or a fatal error. I do realize the alarm triggered by this layout breakage but the modal content is still readable and I wouldn't call this a major breakage.
#20
follow-up:
↓ 21
@
5 years ago
- Keywords fixed-major added; commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for 5.2.3 consideration.
#21
in reply to:
↑ 20
@
5 years ago
Replying to afercia:
Reopening for 5.2.3 consideration.
Love this! Anytime we can lose a div and use default positioning instead of relative / absolute on parent / child, I'm for it!
Also, thanks for the guidance on gardening!
This ticket was mentioned in Slack in #core by sergey. View the logs.
5 years ago
This ticket was mentioned in Slack in #meta by sergey. View the logs.
5 years ago
#24
@
5 years ago
Great to see progress. So this will be fixed in 5.2.3? When will 5.2.3 be available?
#28
in reply to:
↑ 27
@
5 years ago
Replying to hatschiii:
Any news when 5.2.3 will be available?
There is no date yet, please follow https://make.wordpress.org/core/ for announcements.
This ticket was mentioned in Slack in #core by earnjam. View the logs.
5 years ago
#31
@
5 years ago
This should be fixed asap, because people notice this. In this way WP gets a bad rep.
This ticket was mentioned in Slack in #core by remzicavdar. View the logs.
5 years ago
This ticket was mentioned in Slack in #core by remzicavdar. View the logs.
5 years ago
#35
@
5 years ago
This issue is fixed in trunk. If there is a 5.2.3, then it will be included in that. If not, then it will be fixed in 5.3, which is tentatively targeted for late September/early October.
This ticket was mentioned in Slack in #core by remzicavdar. View the logs.
5 years ago
#39
@
5 years ago
To skipp such an issue which is fixed for severall month is a shame! Many WordPress user does nor realize that the informations are there when they scroll down!
#40
follow-up:
↓ 41
@
5 years ago
Hi @hatschiii, thank you for following this ticket,
We are not ignoring the issue, it was committed 4 weeks ago and it will be fixed when 5.2.3 will be released.
If you want, you can also weight on the next minor release schedule: 5.2.3 planning is publicly discussed every Wednesday at 20:00 UTC in the #core Slack channel (https://make.wordpress.org/chat/) during the dev-chat meeting. You're more than welcome to join and weight on the planning if you want to.
#41
in reply to:
↑ 40
@
5 years ago
Replying to audrasjb:
Hi @hatschiii, thank you for following this ticket,
We are not ignoring the issue, it was committed 4 weeks ago and it will be fixed when 5.2.3 will be released.
If you want, you can also weight on the next minor release schedule: 5.2.3 planning is publicly discussed every Wednesday at 20:00 UTC in the #core Slack channel (https://make.wordpress.org/chat/) during the dev-chat meeting. You're more than welcome to join and weight on the planning if you want to.
And if you read what was discussed in the last Dev Chat Meeting last Wednesday it doesn't look like that 5.2.3 is comming. However this is a very visible bug which ist solved since several weeks. I donot understand why there is no update right now!?
Popup Layout Issue