Opened 20 months ago
Last modified 20 months ago
#47564 new defect (bug)
Protect against recursive customizer navigation menu data — at Version 5
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Customize | Keywords: | has-patch reporter-feedback |
Focuses: | Cc: |
Description (last modified by )
Recursive data can slip into navigation menu structure but client-script currently has no protection against, resulting in browser freezing when trying to edit navigation menus.
Attached patch changes getDepth()
to keep track of parent navigation menu item ID to avoid recursion.
Change History (6)
#2
in reply to:
↑ 1
@
20 months ago
Replying to dlh:
Hey @donpark — thanks for submitting this report and patch. Are you able to provide steps to replicate the bug in core?
Only in context of a particular site on WordPress.com. And testing plan, detailed in the A8C internal Phabricator patch I mentioned (D29638-code), requires the tester be an Automattician.
Given these obstacles, I think this ticket is best assigned to an Automattician with WP.org commit privileage.
- Don
#3
follow-up:
↓ 4
@
20 months ago
- Version trunk deleted
OK. Speaking for myself, there's nothing I can do to "assign" the ticket to anyone. So, absent more information, I'm not sure what to do other than wait for an Automattician to volunteer to try to confirm that there's a bug in core and, if so, how to replicate it. (To that end, I'll leave the reporter-feedback
tag on the ticket for now.)
#4
in reply to:
↑ 3
@
20 months ago
Replying to dlh:
OK. Speaking for myself, there's nothing I can do to "assign" the ticket to anyone. So, absent more information, I'm not sure what to do other than wait for an Automattician to volunteer to try to confirm that there's a bug in core and, if so, how to replicate it. (To that end, I'll leave the
reporter-feedback
tag on the ticket for now.)
Fair enough. I'll see if I can get someone here to pick up the baton. Thx for the help, David. :-)
Hey @donpark — thanks for submitting this report and patch. Are you able to provide steps to replicate the bug in core?