Remove unnecessary !important from wp-admin/css/common.css

[foack]

There are 21 !important statements in common.css, that sometimes simply overwrite CSS changes made in JS, overwrite other !important statements in the same file or other files. Overall, it doesn't help with clarity :)

[foack]

updated version of postbox.js

[foack]

Replying to foack:

There are 21 !important statements in common.css, that sometimes simply overwrite CSS changes made in JS, overwrite other !important statements in the same file or other files. Overall, it doesn't help with clarity :)

Please ignore the uploaded common.css and 47569.diff - those are here forever but don't actually contribute to clarity and do not move the ticket further.

[foack]

Updated postbox.js and the statement that added overflow:hidden to #wpbody-content, so that the !important statement on overflow:visible in common.css line 29 can be removed.

[foack]

Updated postbox.js

[foack]

Updated common.css

[foack]

Updated common-rtl.css

[SergeyBiryukov]

Related: #26350

[SergeyBiryukov]

Hi @foack, welcome to WordPress Trac! Thanks for the ticket and the patches.

Could you upload a version of 47569-postbox.js.diff​ without the formatting changes? It's hard to see what's actually changed there.

[foack]

postbox.js without formatting changes.

[foack]

Sure thing @SergeyBiryukov, sorry that I forgot to disable my auto-formatting the first time. WCEU was too exciting :)

Let me know if the new diff helps to clarify!

[davidbaumwald]

@SergeyBiryukov Can this be included in time for 5.3 Beta 1 today?

[davidbaumwald]

The deadline for features and enhancements for version 5.3 Beta 1 has now passed. Moving this to Future Release.

[sabernhardt]

These styles are at the beginning of this list from WP 5.3.2 core:
​https://docs.google.com/spreadsheets/d/1WCuUXfm_WSx7wYFlZ3h8_yLaLxoganyBcPys0TKfoRY/edit?usp=sharing

Column D gives any explanatory notes that are already in each file. If you have something to add to columns E through G, you can use comments within the spreadsheet.

[isabel_brison]

I have tested these changes by applying the patches locally and going through all the screens in wp-admin at different screen widths and in RTL mode. I also tested the classic editor view. Nothing is breaking, in fact, nothing is changing at all :)

[audrasjb]

Administration: Remove unnecessary !important CSS rules from common.css

[audrasjb]

In 47569.4.diff, I put together a patch using the previous proposals.

[whyisjake]

In 48129:

Administration: Remove unnecessary !important CSS rules from common.css

Fixes #47569.

Props foack, SergeyBiryukov, davidbaumwald, sabernhardt, isabel_brison, audrasjb.