#47569 closed enhancement (fixed)
Remove unnecessary !important from wp-admin/css/common.css
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | ui, administration | Cc: |
Description
There are 21 !important
statements in common.css, that sometimes simply overwrite CSS changes made in JS, overwrite other !important
statements in the same file or other files. Overall, it doesn't help with clarity :)
Attachments (7)
Change History (24)
#1
in reply to:
↑ description
@
21 months ago
Replying to foack:
There are 21
!important
statements in common.css, that sometimes simply overwrite CSS changes made in JS, overwrite other!important
statements in the same file or other files. Overall, it doesn't help with clarity :)
Please ignore the uploaded common.css and 47569.diff - those are here forever but don't actually contribute to clarity and do not move the ticket further.
#2
@
21 months ago
Updated postbox.js and the statement that added overflow:hidden
to #wpbody-content
, so that the !important
statement on overflow:visible
in common.css
line 29 can be removed.
#3
@
21 months ago
- Keywords has-patch needs-testing needs-design-feedback added; needs-patch removed
- Type changed from defect (bug) to enhancement
#6
@
20 months ago
- Keywords needs-refresh added
Hi @foack, welcome to WordPress Trac! Thanks for the ticket and the patches.
Could you upload a version of 47569-postbox.js.diff without the formatting changes? It's hard to see what's actually changed there.
#7
@
20 months ago
Sure thing @SergeyBiryukov, sorry that I forgot to disable my auto-formatting the first time. WCEU was too exciting :)
Let me know if the new diff helps to clarify!
#8
@
20 months ago
- Keywords needs-refresh removed
- Milestone changed from Awaiting Review to 5.3
- Owner changed from foack to SergeyBiryukov
- Status changed from assigned to reviewing
#10
@
17 months ago
- Milestone changed from 5.3 to Future Release
The deadline for features and enhancements for version 5.3 Beta 1 has now passed. Moving this to Future Release
.
#11
@
13 months ago
These styles are at the beginning of this list from WP 5.3.2 core:
https://docs.google.com/spreadsheets/d/1WCuUXfm_WSx7wYFlZ3h8_yLaLxoganyBcPys0TKfoRY/edit?usp=sharing
Column D gives any explanatory notes that are already in each file. If you have something to add to columns E through G, you can use comments within the spreadsheet.
#12
@
12 months ago
- Keywords commit added; needs-testing needs-design-feedback removed
I have tested these changes by applying the patches locally and going through all the screens in wp-admin at different screen widths and in RTL mode. I also tested the classic editor view. Nothing is breaking, in fact, nothing is changing at all :)
updated version of postbox.js