WordPress.org

Make WordPress Core

Opened 23 months ago

Closed 2 months ago

Last modified 2 months ago

#47574 closed defect (bug) (fixed)

Public custom post status cannot be embedded

Reported by: goaroundagain Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.2.2
Component: Embeds Keywords: has-unit-tests has-patch has-dev-note
Focuses: Cc:

Description

Currently it is not possible to embend any post with a custom post status, even when the custom post status is set to

'public' => true

From register_post_status: https://codex.wordpress.org/Function_Reference/register_post_status
public: (bool) (optional) Whether posts of this status should be shown in the front end of the site.

For this reason, all post with a custom post status set to public should be embeddable.

The reason why thats not possible is in get_oembed_response_data: https://developer.wordpress.org/reference/functions/get_oembed_response_data/

if ( 'publish' !== get_post_status( $post ) ) {
    return false;
}

It just checks if the post status is "publish" and not if "public" on the post status object is set to "true".

To support custom public post status, this could be a solution:

if ( true !== get_post_status_object( get_post_status( $post ) )->public ) {
    return false;
}

Another possibility would be to provide a custom filter:

if ( true !== in_array( get_post_status( $post ), apply_filters( 'oembed_post_status', array( 'publish' ) ) ) {
    return false;
}

Attachments (3)

47574.diff (408 bytes) - added by goaroundagain 23 months ago.
47574.2.diff (1.8 KB) - added by goaroundagain 23 months ago.
Now with unit tests
47574.3.diff (2.1 KB) - added by goaroundagain 23 months ago.
If the post status is not registered, treat it as a nonpublic

Download all attachments as: .zip

Change History (16)

@goaroundagain
23 months ago

Now with unit tests

#1 @goaroundagain
23 months ago

  • Keywords has-unit-tests has-patch added

@goaroundagain
23 months ago

If the post status is not registered, treat it as a nonpublic

#2 @SergeyBiryukov
23 months ago

  • Milestone changed from Awaiting Review to 5.3

#3 @SergeyBiryukov
21 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Related: #47911

#4 @davidbaumwald
19 months ago

@SergeyBiryukov Is this one going to make it in time for 5.3 RC1?

This ticket was mentioned in Slack in #core by marybaum. View the logs.


19 months ago

#6 @marybaum
19 months ago

  • Milestone changed from 5.3 to Future Release

#7 @SergeyBiryukov
5 months ago

  • Milestone changed from Future Release to 5.7

#8 @poena
3 months ago

I have tested 47574.3.diff and confirmed that posts with a custom post status can be embedded.
-I don't know enough to review the test.

#10 @peterwilsoncc
3 months ago

In the linked pull request, I've modified the patch to use the new `is_post_publicly_viewable()` function which allows for public custom statuses and post types rather than repeat the code.

I've replaced the existing check the post exists, as is_post_publicly_viewable() doesn't consider non-existent post as public. That would be silly :D

#11 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 50401:

Embeds: Allow posts with a public custom post status to be embedded.

Previously, only posts with the publish status could be embedded.

Props goaroundagain, peterwilsoncc, poena.
Fixes #47574.

#13 @desrosj
2 months ago

  • Keywords has-dev-note added

This was mentioned in the miscellaneous developer changes developer note: https://make.wordpress.org/core/2021/02/23/miscellaneous-developer-focused-changes-in-wordpress-5-7/.

Note: See TracTickets for help on using tickets.