WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47606, comment 28


Ignore:
Timestamp:
02/07/2020 09:51:40 AM (6 months ago)
Author:
xkon
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47606, comment 28

    initial v1  
    11I believe that we can move the `prepare_sql_data()` inside the `get_test_sql_server()` to move it out of the constructor as in [attachment:"47606.3.diff"] .
    22
    3 As far as I've seen only the `sql_server` & `utf8mb4_support` tests needs this with the sql_server running first both should be fine. I didn't find any other test needing this at the moment but can't be entirely sure so I'll ping @Clorith here for a check :-).
     3As far as I've seen only the `sql_server` & `utf8mb4_support` tests needs this and with the sql_server running first both should be fine (unless we want to call it again in the utf8mb4 check just for being safe). I didn't find any other test needing this at the moment but can't be entirely sure so I'll ping @Clorith here for a check :-).
    44
    55With this move, the constant calls from every page are also "fixed" as tests would only run under Site Health page.