WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47632, comment 17


Ignore:
Timestamp:
07/05/2019 10:35:47 AM (5 months ago)
Author:
jrf
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47632, comment 17

    initial v1  
    22> @jrf: I haven't upgrade PHPCS, as version 3.4.2 makes a mess of the indenting in some files, I suspect it's something to do with [https://github.com/squizlabs/PHP_CodeSniffer/issues/2450 this fix].
    33
    4 Understood, though I suspect it may have more to do with [the fix for issue](https://github.com/squizlabs/PHP_CodeSniffer/issues/2396). Any particular file you can point me to which shows the incorrect fixes well ?
     4Understood, though I suspect it may have more to do with [https://github.com/squizlabs/PHP_CodeSniffer/issues/2396 the fix for this issue]. Any particular file you can point me to which shows the incorrect fixes well ?
    55
    66I can run some tests to check if it has been corrected again for PHPCS 3.5.0 and if not report the fall-out of the fix upstream.