WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#47665 closed defect (bug) (wontfix)

validator.w3.org errors

Reported by: Omer Faruk Ekinci Owned by: audrasjb
Milestone: Priority: normal
Severity: normal Version:
Component: Gallery Keywords: has-patch needs-testing
Focuses: Cc:

Description

Hi

https://d.pr/free/i/hm29q9 Please fix gallery widgets problem

Ninetheme

Attachments (1)

47665.patch (482 bytes) - added by dkarfa 2 years ago.

Download all attachments as: .zip

Change History (9)

#1 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#2 @audrasjb
2 years ago

  • Keywords needs-unit-tests removed
  • Version trunk deleted

@dkarfa
2 years ago

#3 @swissspidy
2 years ago

  • Keywords has-patch needs-testing added

#4 @audrasjb
2 years ago

  • Keywords 2nd-opinion added

Even if the use of an empty dd element is ok for the validator, the use of a list of definitions with an empty dd element sounds strange to me.

I wonder if we shouldn't simply use an unordered list here.

By the way, I'm ok that the empty dd is a good first way to fixe the validation error.

This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.


2 years ago

#6 @pento
2 years ago

#39058 was marked as a duplicate.

#7 @pento
2 years ago

  • Keywords 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from reviewing to closed

Thank you for the bug report, @omer-faruk-ekinci!

While this report is valid, I'm going to close this ticket, for a few reasons:

  • This seems to only be an issue for the w3 validator, there are no reports of browsers or screen readers having issues with the lack of <dd> element.
  • This only affects the gallery shortcode in the classic editor (or classic block in the block editor). Both of these use cases are heading in to long term maintenance mode, during which minor bug fixes are unlikely to land.
  • It would require a non-trivial amount of time to test and ensure this change doesn't accidentally cause other issues.

#8 @SergeyBiryukov
2 years ago

  • Component changed from Widgets to Gallery
Note: See TracTickets for help on using tickets.