WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47688 closed defect (bug) (fixed)

Color hex code in color picker displayed in RTL instead of LTR on RTL install (take 2)

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2.3 Priority: normal
Severity: normal Version:
Component: Customize Keywords: needs-testing fixed-major
Focuses: ui, rtl Cc:

Description

Background: #23740

  1. Switch to an RTL locale, e.g. Hebrew.
  2. Switch to a theme that uses color picker in Customizer settings, e.g. Twenty Seventeen.
  3. Click the Select Color button.
  4. The hex value input box shows RRGGBB# instead of #RRGGBB.

This was fixed in [23777], however the changes were lost after switching to the new build process in [25001].

Thanks @vjik for noticing!

Change History (3)

#1 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45626:

Customize: Fix text direction for color picker in RTL.

Props vjik for the report.
Fixes #47688. See #23740.

#2 @JeffPaul
5 years ago

  • Keywords needs-testing fixed-major added
  • Milestone changed from 5.3 to 5.2.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

#3 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45830:

Customize: Fix text direction for color picker in RTL.

Props vjik, SergeyBiryukov.
Merges [45626] to the 5.2 branch.
Fixes #47688. See #23740.

Note: See TracTickets for help on using tickets.