Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#47688 closed defect (bug) (fixed)

Color hex code in color picker displayed in RTL instead of LTR on RTL install (take 2)

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Priority: normal Milestone: 5.2.3
Component: Customize Version:
Severity: normal Keywords: needs-testing fixed-major
Cc: Focuses: ui, rtl

Description

Background: #23740

  1. Switch to an RTL locale, e.g. Hebrew.
  2. Switch to a theme that uses color picker in Customizer settings, e.g. Twenty Seventeen.
  3. Click the Select Color button.
  4. The hex value input box shows RRGGBB# instead of #RRGGBB.

This was fixed in [23777], however the changes were lost after switching to the new build process in [25001].

Thanks @vjik for noticing!

Change History (3)

#1 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolutionfixed
  • Status newclosed

In 45626:

Customize: Fix text direction for color picker in RTL.

Props vjik for the report.
Fixes #47688. See #23740.

#2 @JeffPaul
7 years ago

  • Keywords needs-testing fixed-major added
  • Milestone 5.35.2.3
  • Resolution fixed
  • Status closedreopened

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

#3 @SergeyBiryukov
7 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 45830:

Customize: Fix text direction for color picker in RTL.

Props vjik, SergeyBiryukov.
Merges [45626] to the 5.2 branch.
Fixes #47688. See #23740.

Note: See TracTickets for help on using tickets.