WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47689 closed defect (bug) (invalid)

Editor Google Font Error 400

Reported by: jtsng8's profile jtsng8 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Script Loader Keywords:
Focuses: Cc:

Description

Received Error 400 When site language is set to Traditional Chinese and in editor page

the plus sign is converted to %2B
​https://fonts.googleapis.com/css?family=Noto%2BSerif%3A400%2C400i%2C700%2C700i&ver=5.2.2
​https://fonts.googleapis.com/css?family=Noto+Serif%3A400%2C400i%2C700%2C700i&ver=5.2.2

Attachments (1)

47689.diff​ (626 bytes) - added by mukesh27 5 years ago.
Patch.

Download all attachments as: .zip

Change History (3)

#1 @mukesh27
5 years ago

  • Component changed from Options, Meta APIs to Script Loader
  • Focuses administration added
  • Keywords has-patch dev-feedback added
  • Version 5.2.2 deleted

Hi @jtsng8,

Welcome to WordPress Trac! Thanks for the ticket.

I have replicated the same issue in Chinese (Taiwan) language and _x function generated issue for this language.

In wp-includes/script-loader.php replace below code


$font_family = _x( 'Noto Serif:400,400i,700,700i', 'Google Font Name and Variants' );
Replace to
$font_family = __( 'Noto Serif:400,400i,700,700i' );

@mukesh27
5 years ago

Patch.

#2 @ocean90
5 years ago

  • Focuses administration removed
  • Keywords has-patch dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

This was caused by an incorrect translation. ​Chinese (China) didn't had this issue, Chinese (Taiwan) was ​fixed a while ago and ​Chinese (Hong Kong) is now fixed as well.

Closing as invalid since this was not a bug in WordPress core.

Note: See TracTickets for help on using tickets.