Make WordPress Core

Opened 18 years ago

Closed 17 years ago

#4769 closed defect (bug) (invalid)

Punctuation error on Approve it/Delete it/Spam it pages

Reported by: novasource's profile novasource Owned by:
Milestone: Priority: normal
Severity: trivial Version: 2.2.2
Component: Administration Keywords: needs-patch
Focuses: Cc:

Description

If you click on the Approve it, Delete it, or Spam it links in one of those "Please moderate: [article name]" emails, you get a confirmation that reads:

Caution: You are about to mark the following comment as spam:

Are you sure you want to do that?

The second colon is incorrect. it should be a period.

(The wording is slightly different for the Approve it or Delete it links, but the problem is the same.)

This is super easy to fix, so I suggested 2.2.3 as the milestone.

Attachments (1)

comment.diff (1.1 KB) - added by tmountjr 18 years ago.
fixes punctuation

Download all attachments as: .zip

Change History (10)

#1 in reply to: ↑ description ; follow-up: @foolswisdom
18 years ago

  • Milestone changed from 2.2.3 to 2.3 (trunk)

Replying to novasource:

This is super easy to fix, so I suggested 2.2.3 as the milestone.

Ease of fix isn't the 1st gate, severity of problem is.

@tmountjr
18 years ago

fixes punctuation

#2 in reply to: ↑ 1 @tmountjr
18 years ago

  • Keywords has-patch added

Replying to foolswisdom:

Replying to novasource:

This is super easy to fix, so I suggested 2.2.3 as the milestone.

Ease of fix isn't the 1st gate, severity of problem is.

Yes, but the easier it is to fix, the faster someone whips up a patch. :)

#3 follow-up: @foolswisdom
18 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.3 (trunk) to 2.4 (future)

Seeing the patch now, I feel like this bug is looking at the type of wood a door is made of, when the door doesn't even fit.

Caution: You are about to approve the following comment:

Are you sure you want to do that?

[No]    [Yes]

(Comment Author)
(Author E-mail)
(Comment)
}}

Why doesn't it just say:
Approve the following comment?
[No]                       [Approve]

Or in the case of approval, I don't think AYS should even be necessary. Only the destructive operation delete really needs it, and spam probably should have it as well.

The quality of the interaction could probably even be looked at a higher level, but I don't have the skills ;-)

#4 in reply to: ↑ 3 @novasource
18 years ago

Replying to foolswisdom:

Seeing the patch now, I feel like this bug is looking at the type of wood a door is made of, when the door doesn't even fit.

Haha, what a coincidence: I opened an issue on that a couple of days ago: http://trac.wordpress.org/ticket/4768

#5 @darkdragon
18 years ago

  • Component changed from General to Administration

#6 @darkdragon
18 years ago

  • Severity changed from normal to trivial

#7 @thee17
17 years ago

  • Milestone 2.9 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

A lot has changed since 2.2.2

#8 @thee17
17 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

#9 @thee17
17 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.