WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#47695 closed enhancement (fixed)

i18n/multisite: Contextualize strings in theme update screen

Reported by: audrasjb Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: multisite Cc:
PR Number:

Description

In wp-admin/includes/class-wp-ms-themes-list-table.php file, under get_views function, only the first translatable screen is contextualized. Then, we have a gender issue in fr_FR with the other translatable strings. Thant would be nice to add a context to the other items as well.

switch ( $type ) {
        case 'all':
                $text = _nx( 'All <span class="count">(%s)</span>', 'All <span class="count">(%s)</span>', $count, 'themes' );
                break;
        case 'enabled':
                $text = _n( 'Enabled <span class="count">(%s)</span>', 'Enabled <span class="count">(%s)</span>', $count );
                break;
        case 'disabled':
                $text = _n( 'Disabled <span class="count">(%s)</span>', 'Disabled <span class="count">(%s)</span>', $count );
                break;
        case 'upgrade':
                $text = _n( 'Update Available <span class="count">(%s)</span>', 'Update Available <span class="count">(%s)</span>', $count );
                break;
        case 'broken':
                $text = _n( 'Broken <span class="count">(%s)</span>', 'Broken <span class="count">(%s)</span>', $count );
                break;
}

Attachments (1)

47695.diff (1.6 KB) - added by audrasjb 4 months ago.
Add some context to theme update table strings

Download all attachments as: .zip

Change History (4)

@audrasjb
4 months ago

Add some context to theme update table strings

#1 @audrasjb
4 months ago

  • Keywords has-patch added; needs-patch removed

#2 @swissspidy
4 months ago

  • Milestone changed from Awaiting Review to 5.3

#3 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45634:

I18N: Add context for theme filter strings in WP_MS_Themes_List_Table::get_views().

Props audrasjb.
Fixes #47695.

Note: See TracTickets for help on using tickets.