Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47710 closed enhancement (fixed)

Hook "do_mu_upgrade" docblock in wrong line

Reported by: chrico's profile ChriCo Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: Administration Keywords: has-patch
Focuses: multisite, coding-standards Cc:

Description

Currently the hook do_mu_upgrade in wp-admin/admin.php L70 has a dockblock which is inside the if-statement and therefor not that easy to parse out for automatic documentation. Also this statement could be improved by adding some early return to the first if - which is already there as exit.


Patch contains:

  1. Replaced {{elseif}} by {{if}}
  2. Moved {{apply_filters}} above the {{if}} to have documentation at the correct position

Attachments (2)

47710.patch (1.7 KB) - added by ChriCo 5 years ago.
47710.1.patch (4.3 KB) - added by dkarfa 5 years ago.

Download all attachments as: .zip

Change History (4)

@ChriCo
5 years ago

@dkarfa
5 years ago

#1 in reply to: ↑ description @SergeyBiryukov
5 years ago

  • Component changed from Formatting to Administration
  • Focuses multisite coding-standards added
  • Milestone changed from Awaiting Review to 5.3

#2 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45643:

Docs: Move the do_mu_upgrade DocBlock out of the preceding if statement.

Props ChriCo, dkarfa.
Fixes #47710.

Note: See TracTickets for help on using tickets.