WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47734 closed enhancement (fixed)

Update printf statements in About/Credits/Feedoms/Privacy pages to be multiline for consistency

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: pento's profile pento
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: coding-standards Cc:

Description

Hello,

Was noticing while reviewing this changeset that many of the printf statements were on a single line and can become lengthy and convoluted.

Uploading a patch to introduce more consistency into these pages by converting them all to multi-line functions with the translator comment as part of the block. This makes it easier to read the string and see the associated parameters easily. Also reduces line lengths.

Cheers

Attachments (1)

47734.diff​ (8.1 KB) - added by garrett-eclipse 5 years ago.
Patch to introduce consistency and make all printf statements multiline

Download all attachments as: .zip

Change History (4)

@garrett-eclipse
5 years ago

Patch to introduce consistency and make all printf statements multiline

#1 @garrett-eclipse
5 years ago

  • Keywords has-patch needs-testing 2nd-opinion added

Uploaded 47734.diff to introduce some consistency to the printf statements and make them easier to read as a developer.

#2 @pento
5 years ago

  • Keywords needs-testing 2nd-opinion removed
  • Milestone changed from Awaiting Review to 5.3
  • Owner set to pento
  • Status changed from new to accepted

#3 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 45660:

Coding Standards: Improve spacing of printf() calls in the admin About pages.

Props garrett-eclipse.
Fixes #47734.

Note: See TracTickets for help on using tickets.