WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#47757 closed defect (bug) (fixed)

Icon is misaligned in "Hide" button on installation screen

Reported by: johnbillion's profile johnbillion Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: Upgrade/Install Keywords: has-screenshots good-first-bug has-patch
Focuses: Cc:

Description (last modified by johnbillion)

On the installation screen (wp-admin/install.php?step=1), the icon in the "Hide" button for the password is misaligned. Tested in latest Firefox and Chrome on macOS 10.14.

https://core.trac.wordpress.org/raw-attachment/ticket/47757/hide.png

Attachments (2)

hide.png​ (6.8 KB) - added by johnbillion 5 years ago.
47757.patch​ (435 bytes) - added by nmenescardi 5 years ago.

Download all attachments as: .zip

Change History (11)

@johnbillion
5 years ago

#1 @johnbillion
5 years ago

  • Keywords has-screenshots added

#2 @johnbillion
5 years ago

  • Description modified (diff)

#3 @SergeyBiryukov
5 years ago

  • Keywords good-first-bug added

@nmenescardi
5 years ago

#4 @SergeyBiryukov
5 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
5 years ago

  • Version set to trunk

Appears to be a regression in [45476], which changed line-height: 26px; for .wp-core-ui .button to line-height: 2;. The resulting value for .wp-hide-pw > .dashicons is now 40px instead of 20px.

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#6 @SergeyBiryukov
5 years ago

Incidentally, fixing #35776 also fixes this (after removing .wp-hide-pw > .dashicons { line-height: inherit; }, as there are some styles for this button​ currently used in the admin, but not on the installation screen.

#7 @nmenescardi
5 years ago

I tried only removing .wp-hide-pw > .dashicons { line-height: inherit; } but it wasn't enough to center the icon

#8 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45673:

Upgrade/Install: Bring some consistency to installation screen styles.

  • Include forms.css and l10n.css, for consistency with login screen and other admin screens.
  • Remove redundant @import directives from login.css for files already declared as dependencies.
  • Adjust margin on password strength meter for consistency with other fields.
  • Increase font size for "You will need this password to log in" notice.
  • Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@…, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.

#9 @SergeyBiryukov
5 years ago

In 45844:

Upgrade/Install: Bring some consistency to installation screen styles.

  • Include forms.css and l10n.css, for consistency with login screen and other admin screens.
  • Remove redundant @import directives from login.css for files already declared as dependencies.
  • Adjust margin on password strength meter for consistency with other fields.
  • Increase font size for "You will need this password to log in" notice.
  • Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@…, bassgang, cdog, johnbillion, nmenescardi, mukesh27, alpipego, SergeyBiryukov.
Merges [45673] to the 5.2 branch.
Fixes #35776, #43483, #47757, #47758.

Note: See TracTickets for help on using tickets.