WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47767, comment 38


Ignore:
Timestamp:
08/12/2019 02:02:23 AM (6 years ago)
Author:
noisysocks
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #47767, comment 38

    initial v1  
    11This looks great! It's nice that we're able to avoid so much repetition. I applied [attachment:"47767.16.diff"] and tested all of the commands on my macOS machine and it's working as before.
    22
    3 I noticed some places where the JavaScript doesn't quite follow our JavaScript coding standards and so ran the Gutenberg lint tool on these changes:
     3I noticed some places where the JavaScript doesn't quite follow our JavaScript coding standards and so ran the Gutenberg lint tool on these changes, see below. (Does Core have a similar tool? Could we get it to check these new files?)
    44
    55{{{