Add autocomplete support in code editor for php mode

[ediamin]

In plugins editor or theme editor pages WP uses the code-editor.js to implement CodeMirror and its autocomplete feature. But in those pages we are settings $mode = 'php' but code-editor.js supports $mode = 'application/x-httpd-php' for autocompletion. This patch includes a small change to support for php mode also.

[SergeyBiryukov]

Introduced in [41376].

[SergeyBiryukov]

Hi @ediamin, welcome to WordPress Trac!

Thanks for the patch, it works as expected in my testing.

Since wp_get_code_editor_settings()​ explicitly sets mode to 'php' when $type is 'application/x-httpd-php', I think it's safe to just replace application/x-httpd-php with php here.

[ediamin]

Update patch. Only using php and remove application/x-httpd-php

[SergeyBiryukov]

In 45670:

Code Editor: Check for correct mode value in wp.codeEditor.initialize to enable autocomplete support for PHP.

Props ediamin.
Fixes #47769.

[desrosj]

Mentioned in the Miscellaneous Developer Focused Changes dev note for 5.3: ​https://make.wordpress.org/core/2019/10/15/miscellaneous-developer-focused-changes-in-5-3/

[SergeyBiryukov]

#42109 was marked as a duplicate.