WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 12 months ago

#47778 closed defect (bug) (wontfix)

Unexpected unknown propertys in wp-includes/js/crop/cropper.css

Reported by: ozmatflc Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.2.2
Component: Customize Keywords:
Focuses: Cc:

Description

Line 88: wid\th: 6px;

Is the backslash intentional?

Change History (5)

#1 in reply to: ↑ description @ozmatflc
2 years ago

Replying to ozmatflc:

Line 88: wid\th: 6px;

Is the backslash intentional?

Same in line 89: hei\ght: 6px;

#2 @tobifjellner
2 years ago

The comment in line 84 hints that this probably is intentional:

/* fix IE 5 box model */

#3 follow-up: @SergeyBiryukov
2 years ago

  • Component changed from General to Customize
  • Keywords close added

Hi @ozmatflc, welcome to WordPress Trac! Thanks for the ticket.

Introduced in [4629], replaced with Jcrop in [10846], replaced with imgAreaSelect in [14907].

Yes, this appears to be a "CSS hack" for IE 5. While that browser is no longer supported, these older libraries are only kept for backward compatibility, I don't see a benefit in editing them.

#4 @desrosj
2 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thanks again for the ticket, @ozmatflc!

I agree with @SergeyBiryukov here, so I am going to close this out.

Hope to see more tickets from you in the near future!

#5 in reply to: ↑ 3 @SIRavecavec
12 months ago

Replying to SergeyBiryukov:

Hi @ozmatflc, welcome to WordPress Trac! Thanks for the ticket.

Introduced in [4629], replaced with Jcrop in [10846], replaced with imgAreaSelect in [14907].

Yes, this appears to be a "CSS hack" for IE 5. While that browser is no longer supported, these older libraries are only kept for backward compatibility, I don't see a benefit in editing them.

The benefits to edit and fix them, is code quality, passing security validation and internal audits!

I am still not sure why the OLD mentality if its not bothering me and is not burning, let it be.

Its easy to say wont be taken out for backward compatibilty, so lets start building software backwards not forward moving.

I was just about to open a ticket while this came out with many other on a sonarqube test done recently.

No matter what hack that is for what purpose, first of all has no meaning at all to keep it, second of all it invalidates a file that has entire rest of code clean up to that point.

So again what is with this approach that keeps core code bloated with errors same with jQuery and many other sides that have known vulnerabilities for years now and if a few of them arent properly exploited, let's not move on to fix them.

Note: See TracTickets for help on using tickets.