WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#47780 closed defect (bug) (fixed)

"#adminmenu .wp-submenu a" split across two locations

Reported by: ozmatflc Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 3.9
Component: Administration Keywords: good-first-bug has-patch
Focuses: ui Cc:
PR Number:

Description

In wp-admin/css/admin-menu-rtl.css, both line 167 and line 281 define attributes for

#adminmenu .wp-submenu a

Is this intentional? Why not just one definition?

Attachments (1)

47780.diff (741 bytes) - added by AkSDvP 6 months ago.
Please find a patch with an update, I have merged css styles of #adminmenu .wp-submenu a, kindly review & confirm the updates.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
6 months ago

  • Component changed from General to Administration
  • Focuses ui added
  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 5.3
  • Version changed from 5.2.2 to 3.9

Hi @ozmatflc, welcome to WordPress Trac! Thanks for the ticket.

Introduced in [27832]. Merging these blocks seems fine, are you interested in working on a patch?

Please note that admin-menu-rtl.css is auto-generated, admin-menu.css should be patched instead.

@AkSDvP
6 months ago

Please find a patch with an update, I have merged css styles of #adminmenu .wp-submenu a, kindly review & confirm the updates.

#2 @AkSDvP
6 months ago

  • Keywords has-patch added; needs-patch removed

#3 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45682:

Administration: Merge CSS rules for #adminmenu .wp-submenu a in one place.

Props ozmatflc, AkSDvP.
Fixes #47780.

Note: See TracTickets for help on using tickets.