Opened 5 years ago
Closed 5 years ago
#47811 closed enhancement (fixed)
Twenty Nineteen: Improve compatibility with custom colors in the separator block.
Reported by: | kjellr | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description (last modified by )
There's a new Gutenberg feature that adds custom color support to the separator block:
https://github.com/WordPress/gutenberg/pull/16784
The custom color functionality added in that ticket is incompatible with Twenty Nineteen. The theme's styles override the custom colors in a couple places, and result in a mismatch between the front end and the editor. I'm attaching a small patch to fix that.
The separator color functionality is set for the 6.3 release of Gutenberg, so this should be fixed in Twenty Nineteen before that version is merged in, in order to ensure that the theme works with that functionality at launch.
To test:
- Run a development version of Gutenberg with
master
active (or, wait until Gutenberg 6.3 is available in plugin form, and test with that) - Start a post with all three styles of the separator block. Ensure that by default, these appear as intended in the editor and in the front end.
- Using the new sidebar controls, assign a color to each of the separators, and ensure that the new color shows up in the editor and in the front end.
Before
Editor
Front End
After
Editor
Front End
Attachments (1)
Change History (4)
Note: See
TracTickets for help on using
tickets.
In 45920: