WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47811


Ignore:
Timestamp:
07/31/2019 06:49:54 PM (2 years ago)
Author:
kjellr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47811 – Description

    initial v1  
    1 There's a soon-to-land Gutenberg PR that adds custom color support to the separator block:
     1There's a new Gutenberg feature that adds custom color support to the separator block:
    22
    33https://github.com/WordPress/gutenberg/pull/16784
     
    55The custom color functionality added in that ticket is incompatible with Twenty Nineteen. The theme's styles override the custom colors in a couple places, and result in a mismatch between the front end and the editor. I'm attaching a small patch to fix that.
    66
    7 This should be fixed ideally before that change is merged in, in order to ensure that the theme works with that functionality at launch.
     7The separator color functionality is set for the 6.3 release of Gutenberg, so this should be fixed in Twenty Nineteen before that version is merged in, in order to ensure that the theme works with that functionality at launch.
    88
    99----
     
    1111To test:
    1212
    13 - Run a development version of Gutenberg with this PR active: https://github.com/WordPress/gutenberg/pull/16784
    14 - (Or, wait until that PR is merged, and then run that)
     13- Run a development version of Gutenberg with `master` active (or, wait until Gutenberg 6.3 is available in plugin form, and test with that)
    1514- Start a post with all three styles of the separator block. Ensure that by default, these appear as intended in the editor and in the front end.
    1615- Using the new sidebar controls, assign a color to each of the separators, and ensure that the new color shows up in the editor and in the front end.