WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#47811 closed enhancement

Twenty Nineteen: Improve compatibility with custom colors in the separator block. — at Initial Version

Reported by: kjellr Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

There's a soon-to-land Gutenberg PR that adds custom color support to the separator block:

https://github.com/WordPress/gutenberg/pull/16784

The custom color functionality added in that ticket is incompatible with Twenty Nineteen. The theme's styles override the custom colors in a couple places, and result in a mismatch between the front end and the editor. I'm attaching a small patch to fix that.

This should be fixed ideally before that change is merged in, in order to ensure that the theme works with that functionality at launch.


To test:

  • Run a development version of Gutenberg with this PR active: https://github.com/WordPress/gutenberg/pull/16784
  • (Or, wait until that PR is merged, and then run that)
  • Start a post with all three styles of the separator block. Ensure that by default, these appear as intended in the editor and in the front end.
  • Using the new sidebar controls, assign a color to each of the separators, and ensure that the new color shows up in the editor and in the front end.

Before

Editor

https://cldup.com/guK2WwJvwB-3000x3000.png

Front End

https://cldup.com/Fpbel8TYAm-3000x3000.png

After

Editor

https://cldup.com/zukGKwF6NN-3000x3000.png

Front End

https://cldup.com/sbs8Tnfods-1200x1200.png

Change History (1)

@kjellr
2 years ago

Note: See TracTickets for help on using tickets.