WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47889, comment 2


Ignore:
Timestamp:
08/17/2019 02:20:53 PM (2 years ago)
Author:
donmhico
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47889, comment 2

    initial v1  
    44
    55In my attached patch, [https://core.trac.wordpress.org/attachment/ticket/47889/47889.diff 47889.diff], you'll see that I removed the wrapping `esc_url()`. I think it's safe to do this since the image url comes from `wp_get_attachment_image_src()` which is expected to return an array with a url as the first element if the image exist.
     6
     7Reference:
     8https://developer.wordpress.org/reference/functions/wp_get_attachment_image_src/