WordPress.org

Make WordPress Core

Opened 5 weeks ago

Closed 12 days ago

Last modified 12 days ago

#47893 closed defect (bug) (fixed)

Comment Status Metabox: Replace @ with 'at' in the displayed date format

Reported by: birgire Owned by: audrasjb
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch has-screenshots
Focuses: accessibility, administration Cc:

Description

Replace the @ symbol with at in the displayed Submitted On date format for comments.

Example location: /wp-admin/comment.php?action=editcomment&c=123

Related #47832

Attachments (4)

replace-att-in-comment-save-metabox-before-and-after.png (22.7 KB) - added by birgire 5 weeks ago.
47893.diff (2.1 KB) - added by birgire 5 weeks ago.
47893.2.diff (2.2 KB) - added by audrasjb 4 weeks ago.
Adding back the link to PHP Date documentation
47893.3.diff (2.2 KB) - added by audrasjb 2 weeks ago.
Patch refreshed

Download all attachments as: .zip

Change History (18)

@birgire
5 weeks ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 weeks ago

#2 @audrasjb
4 weeks ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#3 @audrasjb
4 weeks ago

  • Milestone changed from Awaiting Review to 5.3

#4 @afercia
4 weeks ago

Discussed during today's accessibility bug scrub. #47832 is related, milestoned for 5.3, and has a patch. Milestoned this for 5.3 as well.

@audrasjb
4 weeks ago

Adding back the link to PHP Date documentation

#5 @audrasjb
4 weeks ago

Hi,

The proposed patch is working fine on my side.

@birgire, in 47893.2.diff, I propose to re-add the link to PHP Date documentation, so polyglots don't loose that information in the new translation string.

#6 @audrasjb
4 weeks ago

  • Keywords commit added

#7 @afercia
2 weeks ago

  • Keywords needs-refresh added; commit removed

Looks like the patch doesn't apply cleanly any longer, after recent changes.

Worth also noting this patch changes a line in wp-admin/includes/template.php that is already changed in the sibling patch on #47832. Depending on which patch gets committed first, the other one will need to be adjusted accordingly.

Last edited 2 weeks ago by afercia (previous) (diff)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 weeks ago

#9 @audrasjb
2 weeks ago

Related: #47992

@audrasjb
2 weeks ago

Patch refreshed

#10 @audrasjb
2 weeks ago

  • Keywords needs-refresh removed

@afercia I refreshed the patch. Waiting for the other to be committed to see if I need to send a new patch :)

#11 @audrasjb
2 weeks ago

Hmm… it obviously sure that we'll need a new patch when #47832 get committed. Nevermind.

#12 @SergeyBiryukov
12 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46084:

Accessibility: Comments: Replace @ with at in the displayed date format.

The @ symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47893.

#13 @SergeyBiryukov
12 days ago

In 46085:

Accessibility: Media: Replace @ with at in the displayed date format.

The @ symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props audrasjb, afercia.
Fixes #47893.

Note: See TracTickets for help on using tickets.