WordPress.org

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #47902


Ignore:
Timestamp:
08/20/2019 04:36:17 PM (22 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47902

    • Property Keywords has-patch added
    • Property Owner set to SergeyBiryukov
    • Property Status changed from new to reviewing
    • Property Milestone changed from Awaiting Review to 5.3
  • Ticket #47902 – Description

    initial v3  
    55In wp_insert_user() there is a lot of check of valid data or not, but since wp_pre_insert_user_data, the returned value is not checked at all.
    66
    7 I know, you'll say "hey, you have to return something !" well, yes, but I want to shortcut and forbid this, so actually I'm returning "__return_empty_array" which is doing the job well, BUT is the admin area we still got the message "New user created." like nothing happened.
     7I know, you'll say "hey, you have to return something !" well, yes, but I want to shortcut and forbid this, so actually I'm returning `__return_empty_array` which is doing the job well, BUT is the admin area we still got the message "New user created." like nothing happened.
    88
    99I think we should add a new control here. (see patch)